-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove parentLocator and next button from component picker [FC-0062] #1412
refactor: remove parentLocator and next button from component picker [FC-0062] #1412
Conversation
Thanks for the pull request, @navinkarkera! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1412 +/- ##
==========================================
- Coverage 93.12% 93.12% -0.01%
==========================================
Files 1050 1050
Lines 20140 20132 -8
Branches 4204 4272 +68
==========================================
- Hits 18755 18747 -8
+ Misses 1325 1322 -3
- Partials 60 63 +3 ☔ View full report in Codecov by Sentry. |
Jump to component selection on library selection
4fe7e27
to
76e5c14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well and code looks good! Just asked on Slack about removing the "Next" step
Description
Removes the need to
parentLocator
to component picker and removes next button as well. Now when a user selects a library, they are taken to the next page to select components as no other action is required in library selection page.Supporting information
Testing instructions
Please see openedx/edx-platform#35670